Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create_dist fail with widevine cdm library #1668

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fix create_dist fail with widevine cdm library #1668

merged 1 commit into from
Feb 14, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 14, 2019 •
edited
Loading

We use fake libwidevinecdm.so is used only for building.
During the packaging, file permission is checked by file type(ELF) and
extension. but our fake file is just empty file. So, handling it
explicitly.

This is f/u PR of #1606.

Issue: brave/brave-browser#413

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

yarn create_dist Release and then check rpm and deb files are created w/o error.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong
Fix create_dist fail with widevine cdm library
663cad8 
We use fake libwidevinecdm.so is used only for building.
During the packaging, file permission is checked by file type and
extension. but our fake file is just empty file. So, handling it
explicitly.
@simonhong simonhong added this to the 0.62.x - Nightly milestone Feb 14, 2019
@simonhong simonhong self-assigned this Feb 14, 2019
@simonhong simonhong requested a review from bbondy February 14, 2019 12:45
@bbondy bbondy merged commit 5817510 into master Feb 14, 2019
@simonhong simonhong deleted the linux_widevine branch March 21, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
0.62.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bbondy